Skip to content

fix(storage): preserve node search fields with grouping - #4155

Merged
kkdras merged 1 commit into
mainfrom
kkdras.4151
Jul 27, 2026
Merged

kkdras merged 1 commit into
mainfrom
kkdras.4151

Conversation

@kkdras

@kkdras kkdras commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

Resolves #4151

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
768 765 0 3 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 64.43 MB | Main: 64.43 MB
Diff: +1.22 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Greptile Summary

Preserves node search fields in grouped storage-node requests.

  • Derives the required Host and NodeName fields from the selected columns.
  • Includes those fields in grouped API requests only while search is active.

Confidence Score: 5/5

The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified.

The grouped storage-node query now preserves the selected Host and NodeName data requirements during active searches, and the changed request path remains type-compatible with the existing viewer API.

Important Files Changed

Filename Overview
src/containers/Storage/PaginatedStorageNodes/GroupedStorageNodesComponent.tsx Adds memoized search-field selection and passes the selected fields to grouped storage-node queries during active searches.

Reviews (1): Last reviewed commit: "fix(storage): preserve node search field..." | Re-trigger Greptile

@kkdras
kkdras marked this pull request as ready for review July 23, 2026 11:31
@kkdras
kkdras added this pull request to the merge queue Jul 27, 2026
Merged via the queue into main with commit 8b74cd3 Jul 27, 2026
37 checks passed
@kkdras
kkdras deleted the kkdras.4151 branch July 27, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage node FQDN search does not work with grouping

2 participants