Skip to content

feat: implement tabs move for the Database - #4229

Merged
kkdras merged 6 commits into
mainfrom
kkdras.4190
Aug 13, 2026
Merged

kkdras merged 6 commits into
mainfrom
kkdras.4190

Conversation

@kkdras

@kkdras kkdras commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Resolves #4190
Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
878 875 0 3 0
Test Changes Summary ✨2 🗑️3

✨ New Tests (2)

  1. shows nodes table with memory viewer on database page (tenant/diagnostics/tabs/nodes.test.ts)
  2. shows nodes table with memory viewer on diagnostics page (tenant/diagnostics/tabs/nodes.test.ts)

🗑️ Deleted Tests (3)

  1. TenantOverview — empty tenant info shows an inline response error (errorDisplay/errorDisplay.test.ts)
  2. TenantOverview — empty refresh keeps the last valid overview (errorDisplay/errorDisplay.test.ts)
  3. Nodes tab shows nodes table with memory viewer (tenant/diagnostics/tabs/nodes.test.ts)

Bundle Size: ✅

Current: 65.32 MB | Main: 65.32 MB
Diff: +2.69 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@kkdras

kkdras commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@greptile review
@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f539f4868

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/containers/Tenant/Diagnostics/DiagnosticsPages.ts Outdated
Comment thread src/containers/Tenant/utils/diagnosticsNavigation.ts
@kkdras

kkdras commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@greptile review
@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 443cb1b233

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/containers/Tenant/utils/diagnosticsNavigation.ts
@kkdras
kkdras marked this pull request as ready for review August 12, 2026 15:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 443cb1b233

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/containers/Tenant/utils/diagnosticsNavigation.ts
@kkdras

kkdras commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor Author

We decided not to move the Nodes tab out of Diagnostics entirely. Instead, it will be available in both Database and Diagnostics, following the same approach as Tablets.

This preserves existing links and the object-scoped Nodes view. Legacy navigation remains unchanged.

@kkdras kkdras self-assigned this Aug 13, 2026
@kkdras
kkdras added this pull request to the merge queue Aug 13, 2026
Merged via the queue into main with commit 4c17a39 Aug 13, 2026
17 checks passed
@kkdras
kkdras deleted the kkdras.4190 branch August 13, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement tabs move for the Database (New navigation)

2 participants