Repository navigation
feat: implement button "login with SSO" #4242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
44e27c4
feat: add SSO login option to authentication
kkdras 1542910
Add SSO authentication flow
kkdras 3d116e0
fix(auth): honor oidc capabilities
kkdras c03c6f9
Validate SSO return paths before redirect
kkdras f6ec05f
Gate authentication with meta capabilities
kkdras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import {getSsoReturnTo} from '../utils'; | ||
|
|
||
| describe('getSsoReturnTo', () => { | ||
| test('falls back when the implicit current path is not a safe local path', () => { | ||
| const fallbackPath = '/ui/home'; | ||
|
|
||
| expect( | ||
| getSsoReturnTo({ | ||
| currentUrl: new URL('https://trusted-host//attacker.example'), | ||
| fallbackPath, | ||
| isDirectAuthPage: false, | ||
| returnUrl: undefined, | ||
| }), | ||
| ).toBe(fallbackPath); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the documented multi-cluster setup where
REACT_APP_META_BACKENDcan be a different URL such ashttp://your-meta-host:8765,BaseMetaAPIfetches capabilities from that configured backend, but this line redirects tohttps://<current UI host>/meta/oidc/authorize. The SSO button consequently targets the wrong host and protocol; derive the authorize endpoint from the configured meta-backend base while preserving its scheme and path prefix.AGENTS.md reference: AGENTS.md:L489-L493
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current URL is intentional and follows #257: the UI and YDB Meta are expected to use the same host.
Using REACT_APP_META_BACKEND is not enough for a separate or prefixed backend. After SSO, the browser returns to /meta/oidc/callback, where the session cookie is created. If Meta uses another host, the cookie will belong to that host rather than the UI host.
Supporting a separate Meta host or /api/meta3 requires additional proxy/backend integration, so it is outside the scope of this change.