Repository navigation
fix: preserve page scrolling over popups #4353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StekPerepolnen
merged 8 commits into
ydb-platform:main
from
StekPerepolnen:fix/hover-popup-scroll-container
Sep 14, 2026
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
801fdf5
fix: keep hover popup scrolling in the anchor scroll container
StekPerepolnen 2e80b7c
fix: scope popup scrolling to tables and simplify coverage
StekPerepolnen 8b25a06
fix: scroll the main list without adding popup scrollbars
StekPerepolnen d5eef8f
fix: preserve page scrolling over popups
StekPerepolnen e0c8f5c
fix: preserve popup typography inside page containers
StekPerepolnen 7735f25
test: cover popup portal fallback and fullscreen paths
StekPerepolnen a2a4bcc
fix: keep popups inside the app fullscreen boundary
StekPerepolnen 12110ad
fix: prevent popup clipping inside scroll containers
StekPerepolnen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| export function getPopupScrollContainer(anchor: HTMLElement | null) { | ||
| if (!anchor) { | ||
| return undefined; | ||
| } | ||
| const doc = anchor.ownerDocument; | ||
| let parent = anchor.parentElement; | ||
| while (parent) { | ||
| if ( | ||
| parent === doc.fullscreenElement || | ||
| (/auto|scroll/.test(doc.defaultView?.getComputedStyle(parent).overflowY ?? '') && | ||
| parent.scrollHeight > parent.clientHeight) | ||
|
StekPerepolnen marked this conversation as resolved.
|
||
| ) { | ||
| // Document scrolling already works through the default portal. | ||
| return parent === doc.scrollingElement ? undefined : parent; | ||
| } | ||
|
StekPerepolnen marked this conversation as resolved.
|
||
| parent = parent.parentElement; | ||
| } | ||
| return undefined; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.