Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The changes span Docker isolation, revision resolution, workflows, and report recovery.
Review effort: Lite
Findings: None
What changed in this PR
Adds an optional tests_sha override for Release UI E2E while preserving the existing default behavior.
Changes:
- Supports independent UI and test revisions.
- Isolates frontend and test dependencies in Docker.
- Updates workflows, report recovery, smoke coverage, and tests.
| File | Description |
|---|---|
scripts/playwright-docker.sh |
Supports separate test and frontend sources. |
.github/workflows/scripts/smoke-release-report.js |
Exercises split-source execution and report merging. |
.github/workflows/scripts/resolve-release-ui.js |
Resolves test revisions and dependencies. |
.github/workflows/scripts/release-e2e-report.js |
Preserves and reports test provenance. |
.github/workflows/scripts/__tests__/resolve-release-ui.test.ts |
Tests revision resolution behavior. |
.github/workflows/scripts/__tests__/release-e2e-workflow.test.ts |
Tests workflow wiring. |
.github/workflows/scripts/__tests__/release-e2e-report.test.ts |
Tests provenance fallback and summaries. |
.github/workflows/scripts/__tests__/playwright-docker-release.test.ts |
Tests Docker boundary handling. |
.github/workflows/release-e2e.yml |
Adds and forwards tests_sha. |
.github/workflows/release-e2e-report.yml |
Uses the recorded test revision for merging. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
tests_shainput to Release UI E2E. Leaving it blank keeps the existing behavior: frontend, tests and locked dependencies use the UI revision embedded in the selected YDB release. A supplied full commit SHA selects the tests, snapshots, test-side source imports, Playwright config and dependencies independently.The frontend still comes from the release UI SHA and installs its own dependencies in a separate directory inside the Playwright container. A small config adapter starts
npm startthere; no selected source runs on the host, and no host checkout, credentials or Docker socket is exposed. The Playwright image and report merge use the test revision. Both SHAs appear in provenance and the summary; recovery of older reports defaults the test SHA to the saved UI SHA.Validation: 37 focused contracts, 224 Jest suites / 1995 tests, typecheck, lint, shell/YAML checks, historical-report checks and live read-only resolution of YDB
26.3.1.16with a different test SHA. The existing Docker smoke now exercises two distinct frontend/test source archives and separate dependencies, then merges a report using a test SHA different from the UI SHA. Local Docker is unavailable; this integration smoke runs in Node.js CI.The override must contain tests compatible with the selected UI. This does not adapt scenarios, update snapshots or guarantee that current-main tests support an older UI. Arcadia integration remains separate. Related to #4389.
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 64.93 MB | Main: 64.93 MB
Diff: 0.00 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information
Safe to merge: the distinct-revision release test and report flow completed successfully with isolated frontend and test sources.
What we checked:
Summary
This change adds support for running release E2E tests from an independently pinned test revision while serving the frontend from the release-embedded UI revision. It records both revisions in provenance, derives the Playwright version from the test revision, isolates the two dependency installations, and carries the test revision through report merging and summaries.
Reviews (1) · Last reviewed commit: "ci: allow a separate test revision for r..."