Skip to content

ci: allow a separate test revision for release e2e - #4390

Open
astandrik wants to merge 1 commit into
mainfrom
codex/release-e2e-tests-sha
Open

astandrik wants to merge 1 commit into
mainfrom
codex/release-e2e-tests-sha

Conversation

@astandrik

@astandrik astandrik commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Add an optional tests_sha input to Release UI E2E. Leaving it blank keeps the existing behavior: frontend, tests and locked dependencies use the UI revision embedded in the selected YDB release. A supplied full commit SHA selects the tests, snapshots, test-side source imports, Playwright config and dependencies independently.

The frontend still comes from the release UI SHA and installs its own dependencies in a separate directory inside the Playwright container. A small config adapter starts npm start there; no selected source runs on the host, and no host checkout, credentials or Docker socket is exposed. The Playwright image and report merge use the test revision. Both SHAs appear in provenance and the summary; recovery of older reports defaults the test SHA to the saved UI SHA.

Validation: 37 focused contracts, 224 Jest suites / 1995 tests, typecheck, lint, shell/YAML checks, historical-report checks and live read-only resolution of YDB 26.3.1.16 with a different test SHA. The existing Docker smoke now exercises two distinct frontend/test source archives and separate dependencies, then merges a report using a test SHA different from the UI SHA. Local Docker is unavailable; this integration smoke runs in Node.js CI.

The override must contain tests compatible with the selected UI. This does not adapt scenarios, update snapshots or guarantee that current-main tests support an older UI. Arcadia integration remains separate. Related to #4389.

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
1116 1112 0 4 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 64.93 MB | Main: 64.93 MB
Diff: 0.00 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

RetriggerConfidence Score: 5/5

Safe to merge: the distinct-revision release test and report flow completed successfully with isolated frontend and test sources.

What we checked:

  • Ran the release smoke with distinct pinned UI and test source archives; the container test passed and confirmed that test-only code was loaded from the test source and the started frontend came from the UI source without Playwright installed there; report merging completed with the test revision and retained the HTML report, JSON report, and attachment while leaving the read-only blob input unchanged. T-Rex
  • Before capture exited 1 due to a missing separate-revision runner path (bash: /home/scripts/playwright-docker.sh: No such file or directory); after capture exited 0 and the container test reported 1 passed, the subsequent report merge completed and stated that Release smoke passed with separate frontend/test checkouts, test-revision merge, and HTML, JSON and attachment retained while the input ZIP remained unchanged. T-Rex
Summary

This change adds support for running release E2E tests from an independently pinned test revision while serving the frontend from the release-embedded UI revision. It records both revisions in provenance, derives the Playwright version from the test revision, isolates the two dependency installations, and carries the test revision through report merging and summaries.

Reviews (1) · Last reviewed commit: "ci: allow a separate test revision for r..."

@astandrik
astandrik marked this pull request as ready for review September 22, 2026 14:32
Copilot AI lite review requested due to automatic review settings September 22, 2026 14:32
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T14:36:24.483046Z f25f26f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The changes span Docker isolation, revision resolution, workflows, and report recovery.

Review effort: Lite
Findings: None

What changed in this PR

Adds an optional tests_sha override for Release UI E2E while preserving the existing default behavior.

Changes:

  • Supports independent UI and test revisions.
  • Isolates frontend and test dependencies in Docker.
  • Updates workflows, report recovery, smoke coverage, and tests.
File Description
scripts/​playwright-docker.sh Supports separate test and frontend sources.
.github/​workflows/​scripts/​smoke-release-report.js Exercises split-source execution and report merging.
.github/​workflows/​scripts/​resolve-release-ui.js Resolves test revisions and dependencies.
.github/​workflows/​scripts/​release-e2e-report.js Preserves and reports test provenance.
.github/​workflows/​scripts/​__tests__/​resolve-release-ui.test.ts Tests revision resolution behavior.
.github/​workflows/​scripts/​__tests__/​release-e2e-workflow.test.ts Tests workflow wiring.
.github/​workflows/​scripts/​__tests__/​release-e2e-report.test.ts Tests provenance fallback and summaries.
.github/​workflows/​scripts/​__tests__/​playwright-docker-release.test.ts Tests Docker boundary handling.
.github/​workflows/​release-e2e.yml Adds and forwards tests_sha.
.github/​workflows/​release-e2e-report.yml Uses the recorded test revision for merging.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants