Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Exposes Healthcheck drawer targets to extensions so consumers can preserve cluster/database context across drawer states and reopen flows.
Changes:
- Adds and exports
HealthcheckDrawerExtensionProps. - Supplies targets from all four drawer owners.
- Adds regression coverage for propagation, updates, and compatibility.
- Documents the feature in the changelog.
| File | Description |
|---|---|
src/uiFactory/types.ts |
Defines the public extension props and callback signature. |
src/lib.ts |
Exports the new public type. |
src/containers/Tenants/DatabaseDrawerHealthcheck.tsx |
Provides the database-list target. |
src/containers/Tenant/TenantDrawerHealthcheck.tsx |
Provides the tenant target. |
src/containers/Tenant/Healthcheck/components/HealthcheckDrawer.tsx |
Passes target data to extensions. |
src/containers/Tenant/Healthcheck/components/__test__/HealthcheckDrawerTargets.test.tsx |
Tests target propagation across drawer owners. |
src/containers/Tenant/Healthcheck/components/__test__/HealthcheckDrawerExtension.test.tsx |
Tests extension updates and compatibility. |
src/containers/Clusters/ClusterDrawerHealthcheck.tsx |
Provides the cluster-list target. |
src/containers/Cluster/ClusterDrawerHealthcheck.tsx |
Provides the cluster-page target. |
CHANGELOG.md |
Documents the feature. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4446.
Healthcheck drawer extensions currently receive no target, so a consumer cannot restore cluster/database context on a passive drawer reopen, especially while Healthcheck is loading, has failed, or has no issues.
Pass the existing
HealthcheckAssistantTargettorenderDrawerExtensionthrough the exportedHealthcheckDrawerExtensionProps. All four drawer owners provide the target from their inputs, and target changes reach the existing mounted extension. Callbacks that ignore arguments remain compatible; a missing target leaves automatic binding to the consumer.Validation:
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 65.17 MB | Main: 65.17 MB
Diff: +2.53 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information
The PR appears safe to merge; no outstanding issue was found in its changes.
What we checked:
Summary
Healthcheck drawer extensions now receive the cluster or database target for the open drawer. The target is available even when Healthcheck data is loading or unavailable, so extensions can keep track of drawer context.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Four healthcheck drawer owners] --> B[HealthcheckDrawer] B --> C[renderDrawerExtension] B --> D[Healthcheck content] A -->|current target| B B -->|target prop| CReviews (2) · Last reviewed commit: "chore: merge main into healthcheck drawe..."