Repository navigation
Conversation
…cription update_row authorizes all row writes (INSERT/UPSERT/REPLACE/UPDATE and topic writes), but its tooltip said "Modify existing data rows with UPDATE operations", so users looked for a non-existent insert permission. erase_row reused the same text by copy-paste though it is the DELETE right.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the database Access tab (Grant access → Granular), the descriptions for
update_rowanderase_roware both shown as "Modify existing data rows with UPDATE operations." Both are misleading:update_rowactually authorizes all row writes —INSERT,UPSERT,REPLACEandUPDATE(it is also the right required to write to topics). There is no separate "insert" permission in the YDB access model, so users searching for one conclude inserts can't be granted, whenupdate_rowis exactly the permission to grant.erase_rowreuses theupdate_rowtext verbatim (copy-paste).erase_rowis theDELETEpermission.The permission model (no
insert_row; row writes gated by theUpdateRowaccess right, deletes byEraseRow) is defined in YDB core (viewer ACL dialect,ydb/core/viewer/viewer_acl.h).Fix
Correct the two i18n descriptions in
GrantAccess/i18n/en.json:description_update-row→ clarifies it covers INSERT/UPSERT/REPLACE/UPDATE (and topic writes), and that there is no separate insert permission.description_erase-row→ correct DELETE wording.Pure i18n text change; no logic changes.
Screenshots
The
update_row/erase_rowtooltips render as the subtitle under each right in the Granular view (Rights.tsx→SingleRight).