Skip to content

Understandable transfer errors#16214

Merged
nshestakov merged 6 commits intoydb-platform:mainfrom
nshestakov:TR-error-texts
Mar 26, 2025
Merged

Understandable transfer errors#16214
nshestakov merged 6 commits intoydb-platform:mainfrom
nshestakov:TR-error-texts

Conversation

@nshestakov
Copy link
Copy Markdown
Collaborator

@nshestakov nshestakov commented Mar 25, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nshestakov nshestakov requested a review from a team as a code owner March 25, 2025 13:56
@nshestakov nshestakov requested a review from pixcc March 25, 2025 13:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2025

🟢 2025-03-25 13:57:28 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2025 •
edited
Loading

⚪ 2025-03-25 13:59:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for a657bc2 has started.
⚪ 2025-03-25 14:00:09 UTC Artifacts will be uploaded here
⚪ 2025-03-25 14:03:03 UTC ya make is running...
🟡 2025-03-25 15:01:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19694 18327 0 6 1248 113

⚪ 2025-03-25 15:03:34 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-25 15:15:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
168 (only retried tests) 63 0 2 0 103

⚪ 2025-03-25 15:15:41 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-25 15:36:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
143 (only retried tests) 39 0 0 0 104

🟢 2025-03-25 15:36:49 UTC Build successful.
🟢 2025-03-25 15:37:12 UTC ydbd size 2.2 GiB changed* by -392 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9808a23 merge: a657bc2 diff diff %
ydbd size 2 321 300 104 Bytes 2 321 299 712 Bytes -392 Bytes -0.000%
ydbd stripped size 485 307 456 Bytes 485 307 520 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2025 •
edited
Loading

⚪ 2025-03-25 13:59:58 UTC Pre-commit check linux-x86_64-release-asan for a657bc2 has started.
⚪ 2025-03-25 14:00:14 UTC Artifacts will be uploaded here
⚪ 2025-03-25 14:03:10 UTC ya make is running...
🟡 2025-03-25 15:17:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12162 12054 0 63 14 31

⚪ 2025-03-25 15:18:51 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-25 15:36:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
153 (only retried tests) 116 0 4 3 30

⚪ 2025-03-25 15:36:53 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-25 15:48:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 26 0 4 2 28

🟢 2025-03-25 15:48:42 UTC Build successful.
🟢 2025-03-25 15:49:12 UTC ydbd size 3.8 GiB changed* by -1.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9808a23 merge: a657bc2 diff diff %
ydbd size 4 083 584 232 Bytes 4 083 583 128 Bytes -1.1 KiB -0.000%
ydbd stripped size 1 410 980 552 Bytes 1 410 979 944 Bytes -608 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov requested a review from CyberROFL March 25, 2025 15:53
CyberROFL
CyberROFL reviewed Mar 25, 2025
View reviewed changes
Comment thread ydb/core/tx/replication/service/transfer_writer.cpp Outdated
Comment thread ydb/core/tx/replication/service/transfer_writer.cpp Outdated
@CyberROFL CyberROFL removed the request for review from pixcc March 25, 2025 17:21
@nshestakov @CyberROFL
Update ydb/core/tx/replication/service/transfer_writer.cpp
d370642 
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2025 •
edited
Loading

⚪ 2025-03-26 06:28:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8f568dc has started.
⚪ 2025-03-26 06:28:57 UTC Artifacts will be uploaded here
⚫ 2025-03-26 06:30:20 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2025 •
edited
Loading

⚪ 2025-03-26 06:31:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for a3f5cc0 has started.
⚪ 2025-03-26 06:31:54 UTC Artifacts will be uploaded here
⚪ 2025-03-26 06:34:36 UTC ya make is running...
🟡 2025-03-26 07:32:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19694 18332 0 6 1247 109

⚪ 2025-03-26 07:34:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-26 07:45:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 59 0 0 0 104

🟢 2025-03-26 07:45:38 UTC Build successful.
🟢 2025-03-26 07:45:57 UTC ydbd size 2.2 GiB changed* by -328 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f390e82 merge: a3f5cc0 diff diff %
ydbd size 2 322 183 040 Bytes 2 322 182 712 Bytes -328 Bytes -0.000%
ydbd stripped size 485 455 552 Bytes 485 455 680 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2025 •
edited
Loading

⚪ 2025-03-26 06:31:40 UTC Pre-commit check linux-x86_64-release-asan for a3f5cc0 has started.
⚪ 2025-03-26 06:31:54 UTC Artifacts will be uploaded here
⚪ 2025-03-26 06:34:47 UTC ya make is running...
🟡 2025-03-26 07:50:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12162 12041 0 71 18 32

⚪ 2025-03-26 07:51:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-26 08:04:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
170 (only retried tests) 128 0 3 10 29

⚪ 2025-03-26 08:04:23 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-26 08:16:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 24 0 3 7 28

🟢 2025-03-26 08:16:22 UTC Build successful.
🟢 2025-03-26 08:16:53 UTC ydbd size 3.8 GiB changed* by -1.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f390e82 merge: a3f5cc0 diff diff %
ydbd size 4 085 277 992 Bytes 4 085 276 832 Bytes -1.1 KiB -0.000%
ydbd stripped size 1 411 446 568 Bytes 1 411 445 896 Bytes -672 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov enabled auto-merge (squash) March 26, 2025 08:17
CyberROFL
CyberROFL reviewed Mar 26, 2025
View reviewed changes
Comment thread ydb/core/tx/replication/service/transfer_writer.cpp Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2025 •
edited
Loading

⚪ 2025-03-26 11:49:04 UTC Pre-commit check linux-x86_64-release-asan for 4a99dea has started.
⚪ 2025-03-26 11:49:18 UTC Artifacts will be uploaded here
⚪ 2025-03-26 11:52:07 UTC ya make is running...
🟡 2025-03-26 13:41:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12171 12001 0 116 19 35

⚪ 2025-03-26 13:43:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-26 13:55:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
224 (only retried tests) 186 0 3 6 29

⚪ 2025-03-26 13:55:48 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-26 14:07:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 (only retried tests) 25 0 3 3 27

🟢 2025-03-26 14:07:41 UTC Build successful.
🟡 2025-03-26 14:08:12 UTC ydbd size 3.8 GiB changed* by +231.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 22ccfe5 merge: 4a99dea diff diff %
ydbd size 4 110 540 160 Bytes 4 110 777 064 Bytes +231.4 KiB +0.006%
ydbd stripped size 1 420 396 008 Bytes 1 420 475 592 Bytes +77.7 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2025 •
edited
Loading

⚪ 2025-03-26 11:50:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4a99dea has started.
⚪ 2025-03-26 11:51:08 UTC Artifacts will be uploaded here
⚪ 2025-03-26 11:53:56 UTC ya make is running...
🟡 2025-03-26 13:26:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19703 18342 0 4 1243 114

⚪ 2025-03-26 13:28:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-26 13:45:19 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 58 0 0 0 105

🟢 2025-03-26 13:45:29 UTC Build successful.
🟡 2025-03-26 13:45:48 UTC ydbd size 2.2 GiB changed* by +113.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 22ccfe5 merge: 4a99dea diff diff %
ydbd size 2 342 731 376 Bytes 2 342 847 960 Bytes +113.9 KiB +0.005%
ydbd stripped size 489 884 928 Bytes 489 906 560 Bytes +21.1 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov requested a review from CyberROFL March 26, 2025 14:07
@nshestakov nshestakov merged commit 4863895 into ydb-platform:main Mar 26, 2025
12 checks passed
@nshestakov nshestakov deleted the TR-error-texts branch March 27, 2025 04:37
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@nshestakov @CyberROFL
Understandable transfer errors (ydb-platform#16214)
4c20af4 
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
nshestakov added a commit to nshestakov/ydb that referenced this pull request May 5, 2025
@nshestakov @CyberROFL
Understandable transfer errors (ydb-platform#16214)
4b6de3a 
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nshestakov @CyberROFL