Fix Enter not working in SimpleMDE (go-gitea#11564)

silverwind · Yohann Delafollye · commit 5738f22e56c1 · 2020-07-31T14:29:58.000-04:00
* Fix Enter not working in SimpleMDE This condition was wrongly inverted, leading to all enter keys being blocked. Fixes: go-gitea#11559 * fix it for absent tribute too
diff --git a/web_src/js/index.js b/web_src/js/index.js
@@ -1497,7 +1497,7 @@ function setCommentSimpleMDE($editArea) {
   simplemde.codemirror.setOption('extraKeys', {
     Enter: () => {
       const tributeContainer = document.querySelector('.tribute-container');
-      if (tributeContainer && tributeContainer.style.display !== 'none') {
+      if (!tributeContainer || tributeContainer.style.display === 'none') {
         return CodeMirror.Pass;
       }
     },

Original file line number	Diff line number	Diff line change
`@@ -1497,7 +1497,7 @@ function setCommentSimpleMDE($editArea) {`
`1497`	`1497`	`simplemde.codemirror.setOption('extraKeys', {`
`1498`	`1498`	`Enter: () => {`
`1499`	`1499`	`const tributeContainer = document.querySelector('.tribute-container');`
`1500`		`- if (tributeContainer && tributeContainer.style.display !== 'none') {`
	`1500`	`+ if (!tributeContainer \|\| tributeContainer.style.display === 'none') {`
`1501`	`1501`	`return CodeMirror.Pass;`
`1502`	`1502`	`}`
`1503`	`1503`	`},`