Fix Enter not working in SimpleMDE#11564
Merged
Merged
Conversation
This condition was wrongly inverted, leading to all enter keys being blocked. Fixes: go-gitea#11559
GiteaBot
added
the
lgtm/need 1
Member
Author
|
Backport is not required as #11497 did not land on 1.12. |
techknowlogick
approved these changes
May 22, 2020
GiteaBot
added
lgtm/done
Member
Author
|
Small tweak pushed to also correctly handle the case when tribute is absent. |
Contributor
|
The arrow-up keypress is not handled correct, it moves cursor within SimpleMDE box and pressing enter after using it to to navigate emoji list just closes the box without emoji being inserted. arrow-down works fine. |
Member
Author
|
That does sound like a unrelated issue. I'm not motivated to deal with the CodeMirror/SimpleMDE/Tribute amalgamation, it should be fixed eventually with #10729. |
CirnoT
approved these changes
May 23, 2020
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Fix Enter not working in SimpleMDE This condition was wrongly inverted, leading to all enter keys being blocked. Fixes: go-gitea#11559 * fix it for absent tribute too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This condition was wrongly inverted, leading to all enter keys being blocked.
Fixes: #11559