Skip to content

ListenCommand added to DI. #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

holdmann
Copy link
Contributor

ListenCommand added to DI through config

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.72%. Comparing base (05ab1c0) to head (c7f6e1a).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #243   +/-   ##
=========================================
  Coverage     95.72%   95.72%           
  Complexity      354      354           
=========================================
  Files            46       46           
  Lines           958      958           
=========================================
  Hits            917      917           
  Misses           41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xepozz
Copy link
Member

xepozz commented Apr 19, 2025

What does it improve?

@holdmann
Copy link
Contributor Author

What does it improve?

I use this package outside of the context of yii3, so I have to build the container configuration myself. In order not to do it manually, as a starting point I use di.php. Everything suits for me in this approach except for the absence of the queue:listen command. That's why I created the pull request :)

@xepozz
Copy link
Member

xepozz commented Apr 22, 2025

Everything suits for me in this approach except for the absence of the queue:listen command

When you add a console command to the DI configuration file it does not mean you add the command to console command loader.

Moreover, when you add class => class association to the DI configuration file you do nothing, because it does not define anything new $container->get($class) can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants