Conversation
Member
vjik
commented
Mar 15, 2026
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Tests pass? | ✔️ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #264 +/- ##
============================================
+ Coverage 98.54% 98.57% +0.02%
- Complexity 360 366 +6
============================================
Files 47 48 +1
Lines 964 983 +19
============================================
+ Hits 950 969 +19
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new queue provider implementation that returns queues from a preconfigured in-memory map, enabling simple composition and testing scenarios without factories/containers.
Changes:
- Introduced
PredefinedQueueProviderimplementingQueueProviderInterfaceusing a name→instance map with enum name normalization. - Added unit tests covering
get(),has(), not-found behavior, invalid config, and enum-backed names. - Updated
CompositeQueueProviderTestto usePredefinedQueueProviderfor simpler provider composition.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Provider/PredefinedQueueProvider.php | New provider that returns predefined QueueInterface instances by normalized name. |
| tests/Unit/Provider/PredefinedQueueProviderTest.php | New test suite validating provider behavior and error cases. |
| tests/Unit/Provider/CompositeQueueProviderTest.php | Refactors composite provider test to compose predefined providers instead of adapter-factory providers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samdark
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.