Add stomp driver #260
Add stomp driver #260
Conversation
versh23
commented
Aug 24, 2018
•
versh23
commented
| Q | A |
|---|---|
| Is bugfix? | no |
| New feature? | yes |
| Breaks BC? | no |
| Tests pass? | yes |
| Fixed issues |
|
ping @zhuravljov |
|
@versh23 good work! Thank you for contribution. Sorry, I'm little busy now, and will review and test in the next weekend. |
|
@zhuravljov no problem! thank you for reply |
versh23
force-pushed
the
add-stomp-driver
branch
from
4b111d0 to
c904f18
Compare
|
updated |
|
hmm.. @makasim its ok ? |
|
@versh23 looks good. |
|
@zhuravljov hello! what about testing ? |
versh23
force-pushed
the
add-stomp-driver
branch
from
93b4c6b to
9b41cd6
Compare
|
rebased |
|
active mq close connection, while no message in queue long times and now i want to send alive message to activeMQ ( it can be configurable) |
|
Yes. Just push to the same branch. |
versh23
force-pushed
the
add-stomp-driver
branch
from
3361425 to
1aebfac
Compare
|
@samdark seems enqueue/amqp-lib required php >=7.1.3 and some methods and class has been changes.. what can i do ? revert to older version? |
|
enqueue/amqp-lib 0.8 supports 5.6, new 0.9 (currently in developemnt) require +7.1. Same applies to other enqueue packages too. |
|
php-enqueue/enqueue-dev#552 - could be backported to 0.8 version. |
|
@makasim it would be great! can i make PR in 0.8 branch ? |
|
|
ping @zhuravljov |
|
hm.. i could resolve conflicts fast and my changes would be in 2.2.0 |
versh23
force-pushed
the
add-stomp-driver
branch
from
e094bd0 to
013173e
Compare
…on use queue without some headers ) * use default value ttr if not exists * generate messageId if not exists in headers
bug with empty buffer
|
rebased |
|
@versh23 travis doesn't seem to be happy: https://travis-ci.org/yiisoft/yii2-queue/jobs/538712947 |
|
@samdark yes, this test fails periodically. i work with stomp only. |
|
Merged. Thank you! |
