Skip to content

cleanup dependencies #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinramharak merged 4 commits into from
Oct 19, 2025
Merged

cleanup dependencies #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
598cdf0
cleanup root dependencies; cleanup vscode-extension dependencies
kevinramharak Oct 16, 2025
9801145
fix eslint from working in vscode
kevinramharak Oct 16, 2025
521b71d
fix glob in eslint.config.mjs
kevinramharak Oct 16, 2025
9c62113
remove unused plugin
kevinramharak Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions apps/vscode-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,10 @@
"devDependencies": {
"@types/glob": "^8.1.0",
"@types/mocha": "^10.0.10",
"@types/node": "^20.17.7",
"@types/vscode": "^1.70.0",
"@typescript-eslint/eslint-plugin": "^5.31.0",
"@typescript-eslint/parser": "^5.31.0",
"@vscode/test-electron": "^2.4.1",
"@types/node": "^16.11.68",
"@types/vscode": "^1.77.0",
"@vscode/test-electron": "^2.5.2",
"esbuild": "^0.24.0",
"eslint": "^9.15.0",
"glob": "^8.1.0",
"mocha": "^10.8.2",
"npm-run-all": "^4.1.5"
Expand Down
22 changes: 1 addition & 21 deletions apps/vscode-extension/scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@ async function main() {
define: production ? { "process.env.NODE_ENV": '"production"' } : undefined,
minify: production,
sourcemap: !production,
plugins: [
nodeDepsPlugin,
workspacePackagesPlugin,
esbuildProblemMatcherPlugin,
],
plugins: [workspacePackagesPlugin, esbuildProblemMatcherPlugin],
});
if (watch) {
await ctx.watch();
Expand Down Expand Up @@ -55,22 +51,6 @@ const esbuildProblemMatcherPlugin = {
},
};

/**
* resolve "path" to path-browserify, allows for use of the extension in web environments as well
* @type {import('esbuild').Plugin}
*/
const nodeDepsPlugin = {
name: "node-deps",
setup(build) {
build.onResolve({ filter: /^path$/ }, (args) => {
const path = require.resolve("../node_modules/path-browserify", {
paths: [__dirname],
});
return { path };
});
},
};

/**
* Resolve internal workspace packages to their source files so we bundle them in watch/debug.
* This makes changes in packages/* reflected immediately without separate watchers.
Expand Down
13 changes: 12 additions & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,21 @@

import eslint from "@eslint/js";
import tseslint from "typescript-eslint";
import globals from "globals";

export default tseslint.config(
eslint.configs.recommended,
...tseslint.configs.strict,
...tseslint.configs.stylistic,
{
ignores: ["scripts/*", "out/*", "dist/*", "test/*", ".vscode-test/*"],
ignores: [
"apps/*/scripts/*",
"apps/*/dist/*",
"packages/*/scripts/*",
"packages/*/dist/*",
"examples/*",
".vscode-test/*",
],
},
{
languageOptions: {
Expand All @@ -17,6 +25,9 @@ export default tseslint.config(
ecmaVersion: "latest",
sourceType: "module",
},
globals: {
...globals.node,
},
},
plugins: {
"@typescript-eslint": tseslint.plugin,
Expand Down
Loading