Skip to content

Conversation

@WuMingDao
Copy link

@WuMingDao WuMingDao commented Jan 8, 2026

image

@kevinramharak
Copy link
Collaborator

@WuMingDao Can you show on which platform the shield is broken? The current version works for me on:

The reason we use the ugly inline png version is because img.shields does not provide the VS Code icon in the shield.

@WuMingDao
Copy link
Author

@WuMingDao Can you show on which platform the shield is broken? The current version works for me on:

The reason we use the ugly inline png version is because img.shields does not provide the VS Code icon in the shield.

thank reply, I find in github repo of readme.md page not correct show vscode icon
image

and now use shields can use show vscode icon: this

Visual Studio Code

@kevinramharak
Copy link
Collaborator

I was not aware that the shield does not work on the github repo. It does work on the other pages.
It's a minor thing, but img.shields does not provide Microsoft logos for legal reasons. I think its petty that we can't use the logo, it looks better, but using the one from this PR simplifies the link in the readme. Its up to @yoavbls to decide.

@WuMingDao
Copy link
Author

I was not aware that the shield does not work on the github repo. It does work on the other pages. It's a minor thing, but img.shields does not provide Microsoft logos for legal reasons. I think its petty that we can't use the logo, it looks better, but using the one from this PR simplifies the link in the readme. Its up to @yoavbls to decide.

ok, I see

@kevinramharak kevinramharak requested a review from yoavbls January 8, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants