Skip to content

tests/runc: 13 skipped tests in runc_test_pattern already pass #3843

Open

Description

@nayuta723

Background

tests/runc/runc_test_pattern keeps 13 entries marked [skip] with no reason
comment, but all of them pass against the current main build. The list looks
stale: youki gained support for these cases at some point and the entries were
never re-enabled.

This is independent of #3834, which unskips a different set of entries after
changing the process.terminal default of youki spec.

Tests

  • empty HOME env var is overridden
  • empty HOME env var is overridden with multiple overrides
  • runc run no capability
  • runc run with some capabilities
  • runc run with new privileges
  • runc run with RLIMIT_NOFILE(The same as system's hard value)
  • runc run [/proc is a symlink]
  • runc run [redundant default /dev/tty]
  • runc run [ro /sys/fs/cgroup mounts + cgroupns]
  • runc run [tmpcopyup]
  • runc run [simple timens]
  • runc run [simple timens + userns]
  • runc run [timens with no offsets]

TODO

  • Drop the [skip] prefix from the entries above
  • Confirm just test-runc-comp still passes

Verification

Ran each entry through just test-runc-comp (i.e. including the script
wrapper) against a main build. All 13 reported ok.
Environment: Fedora 42, aarch64, cgroup v2 unified, runc submodule at
b04031d7. Not verified on x86_64.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions