-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Added generics support for convenience #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @skamenetskiy , |
This reverts commit e00a3ce.
|
Not sure what's wrong with the linter now 😞 |
beside that, I see this changes it not backward compatible and I would say while its a big change , we will bump the version of the gocache and release it as v2. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
===========================================
+ Coverage 94.54% 100.00% +5.45%
===========================================
Files 1 1
Lines 55 44 -11
===========================================
- Hits 52 44 -8
+ Misses 2 0 -2
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Now sounds good to me. |
Looks good 👍🏻 |
Added generics support for convenience. Should be mostly backward compatible.