Skip to content

Conversation

@skamenetskiy
Copy link
Contributor

Added generics support for convenience. Should be mostly backward compatible.

@yuseferi yuseferi changed the title Added generics support for convenience feat: Added generics support for convenience Dec 18, 2025
@yuseferi
Copy link
Owner

Hey @skamenetskiy ,
This is a good idea to make it generic.
Thank you for your collaboration ❤️ 🙏

@skamenetskiy
Copy link
Contributor Author

@yuseferi seems I have broken the pipeline with this commit e00a3ce. Should I revert it?

@yuseferi
Copy link
Owner

@yuseferi seems I have broken the pipeline with this commit e00a3ce. Should I revert it?

yes please, in another PR after we've done with this, I will bump the version, it's been a long time that I have not bumped it ( it is 1.20) :)

This reverts commit e00a3ce.
@skamenetskiy
Copy link
Contributor Author

@yuseferi seems I have broken the pipeline with this commit e00a3ce. Should I revert it?

yes please, in another PR after we've done with this, I will bump the version, it's been a long time that I have not bumped it ( it is 1.20) :)

Done 😄

@skamenetskiy
Copy link
Contributor Author

Not sure what's wrong with the linter now 😞

@yuseferi
Copy link
Owner

Not sure what's wrong with the linter now 😞
I will check it later,

beside that, I see this changes it not backward compatible and I would say while its a big change , we will bump the version of the gocache and release it as v2.
v1 stays as before but v2 supports generic.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ffd7e65) to head (a5b6275).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master        #6      +/-   ##
===========================================
+ Coverage   94.54%   100.00%   +5.45%     
===========================================
  Files           1         1              
  Lines          55        44      -11     
===========================================
- Hits           52        44       -8     
+ Misses          2         0       -2     
+ Partials        1         0       -1     
Flag Coverage Δ
unittests 100.00% <100.00%> (+5.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuseferi
Copy link
Owner

Now sounds good to me.
@skamenetskiy, how about you? :),

@skamenetskiy
Copy link
Contributor Author

Now sounds good to me. @skamenetskiy, how about you? :),

Looks good 👍🏻

@yuseferi yuseferi self-assigned this Dec 18, 2025
@yuseferi yuseferi merged commit 440e0cc into yuseferi:master Dec 18, 2025
6 checks passed
@skamenetskiy skamenetskiy deleted the feature/generics branch December 18, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants