Harden v2 schema hashing: capture more schema detail and fix determin…#4
Open
zachtbeer wants to merge 2 commits into
Open
Harden v2 schema hashing: capture more schema detail and fix determin…#4zachtbeer wants to merge 2 commits into
zachtbeer wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Hardened the v2 schema hash so it stops missing real schema changes and stops producing different hashes for the same schema on different machines.
Schema details it now actually hashes (these used to slip through as identical):
Determinism fixes:
Options: