Bugfix: no stups token bean if not needed#176
Merged
Conversation
ePaul
added
bug
auto-configuration
This was referenced Aug 8, 2023
Draft
When the application already supplies a NakadiPublishingClient or NakadiClient bean, we don't need our own authentication setup. This was already meant to be skipped, but I guess we misunderstood how nested configuration classes work – they don't inherit their outer classes' conditions.
ePaul
force-pushed
the
bugfix-no-stups-token-bean
branch
from
db124f4 to
3bbdf4d
Compare
Member
Author
|
👍 |
1 similar comment
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the application already supplies a NakadiPublishingClient
or NakadiClient bean, we don't need our own authentication setup.
This was already meant to be skipped, but I guess we misunderstood
how nested configuration classes work – they don't inherit their
outer classes' conditions.
As an effect, even when one of these beans is already there, a new
StupsTokenComponent bean was created (and the build failed if that was
not possible e.g. due to missing configuration variables).
This adds a test which checks that the StupsTokenComponent bean is not created
when we got the MockPublishingClient bean. (Fails if just running the first commit.)
We then make the creation of the StupsTokenComponent dependent on missing both beans.
As an effect, when running the tests we don't get all the error messages about missing
CREDENTIALS_DIR environment variables anymore.
As a bonus, we also add an AccessTokenProvider @MockBean to NakadiClientEncodingIT (which doesn't have a NakadiPublishingClient) to avoid getting the error messages about CREDENTIALS_DIR here.