Skip to content
This repository was archived by the owner on Oct 23, 2025. It is now read-only.

Conversation

@jmcs
Copy link
Member

@jmcs jmcs commented Sep 12, 2016

Fixes #346

tags: List[Dict[str, str]]):
self.vpc_id = vpc_id
self.is_default = is_default
self.tags = OrderedDict([(t['Key'], t['Value']) for t in tags]) # type: Dict[str, str]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can make this much shorter by using tags or []

@coveralls
Copy link

coveralls commented Sep 12, 2016

Coverage Status

Coverage decreased (-0.02%) to 89.055% when pulling 29519e6 on tags-and-create into e033177 on master.

@hjacobs
Copy link
Contributor

hjacobs commented Sep 12, 2016

Unit test? 😏

@coveralls
Copy link

coveralls commented Sep 12, 2016

Coverage Status

Coverage increased (+0.003%) to 89.083% when pulling bf7f7be on tags-and-create into e033177 on master.

@coveralls
Copy link

coveralls commented Sep 12, 2016

Coverage Status

Coverage increased (+0.003%) to 89.083% when pulling bf11195 on tags-and-create into e033177 on master.

@hjacobs
Copy link
Contributor

hjacobs commented Sep 12, 2016

👍

@hjacobs hjacobs merged commit 41850ee into master Sep 12, 2016
@rafaelcaricio rafaelcaricio deleted the tags-and-create branch September 12, 2016 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants