chore: update msrv to 1.91.1#3022
Conversation
c53c56c to
a5d6857
Compare
e5412d6 to
e0d8a11
Compare
|
Was "no capture" not working when passed in RUSTDOCFLAGS? |
e0d8a11 to
3836cf0
Compare
I don't know but now it does not build with this in the environment variable |
3836cf0 to
385b819
Compare
nsarlin-zama
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 56 files reviewed, 1 unresolved discussion (waiting on @IceTDrinker, @mayeul-zama, @soonum, and @tmontaigu)
Makefile line 433 at r1 (raw file):
Previously, mayeul-zama wrote…
Was "no capture" not working when passed in RUSTDOCFLAGS?
Now it does not build with this in the environment variable
I added a clippy warning in a doctest to see what happens. |
IceTDrinker
left a comment
There was a problem hiding this comment.
Thanks a lot !
@IceTDrinker reviewed 48 of 49 files at r1, 5 of 5 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mayeul-zama, @soonum, and @tmontaigu)
385b819 to
53556d8
Compare
|
Fix wasm build for this: rust-lang/rust#147225:
The exact line does not work, had to split it into multiple -Clink-arg |
|
over several lines maybe ? 😅 |
53556d8 to
362ef67
Compare
nsarlin-zama
left a comment
There was a problem hiding this comment.
Reviewable status: 55 of 57 files reviewed, 1 unresolved discussion (waiting on @IceTDrinker, @mayeul-zama, @soonum, and @tmontaigu)
Makefile line 655 at r5 (raw file):
Previously, IceTDrinker wrote…
over several lines maybe ? 😅
done
pgardratzama
left a comment
There was a problem hiding this comment.
I am not sure "is_multiple_of(2)" is better than "% 2 == 0" but it does not do any harm.
HPU related tests and noise measures using NTT are ok so let's go.
Thanks!!!
agreed, the lints recommended it, it does not seem to harm the readability of our code so 🤷 |
IceTDrinker
left a comment
There was a problem hiding this comment.
Looks good !
@IceTDrinker reviewed 1 of 2 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mayeul-zama, @soonum, and @tmontaigu)

closes: please link all relevant issues
PR content/description
Update msrv to 1.91.1.
To make this work, I also had to:
This does not include the update to remove the nightly feature, which will come in another pr.
This change is