Prevent page overflow by switching to mobile header at 1000px #3484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
ritorhymes
force-pushed
the
fix-header-overflow
branch
from
1e9bc71 to
3d006a3
Compare
Member
|
There's no point raising an issue if you are going to PR the fix, the website repo does not have that much activity that needs the extra tracking. |
thc202
changed the title
Signed-off-by: Rito Rhymes <[email protected]>
ritorhymes
force-pushed
the
fix-header-overflow
branch
from
3d006a3 to
99e0c3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts media breakpoints so that the mobile version of the header appears at 1000px instead of 825px which fixes the horizontal page overflow caused by the desktop version's header contents not fitting at that original 825px breakpoint. The overflow was causing the page content to be offset left, shrinking the header desktop buttons and adding excess whitespace to the right side of the footer.
Closes #3483
Testing
You can test the fix out on a live demo zaproxy.ritovision.com or on a local build.
To verify, simply go to any page (try the homepage) and adjust your desktop browser screen size anywhere between 826-1000px and notice that the pages no longer have overflow breaking the layout.
I have tested the fix on Chrome, Edge and Firefox desktop browsers and confirmed its stability.
Before and After Screenshots
Top of Homepage - BEFORE
Notice the page content is significantly offset to the left. If you look closely at the line separator under the header, it ends underneath the Download button when it should span the full page; this indicates the header is overflowing and forcing the layout to compress.
Bottom of Homepage - BEFORE
Notice the footer has excess whitespace on its right side (a visual symptom of the page being forced left due to header overflow in this breakpoint range).
Top of Homepage - AFTER
Notice the content is no longer offset left
Bottom of Homepage - AFTER
Notice the footer has no excess whitespace along its right side