Ensure VLen* encode methods return ndarrays
#144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few `VLen*` types that were missed by the previous PR that ensured the `encode` methods all returned `ndarray`s. In particular `VLenBytes` and `VLenArray` were missed. This fixes that oversight by ensuring these also return `ndarray`s.
As there were some changes made to `vlen.pyx`, have Cython regenerate `vlen.c` to include the relevant changes.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR ( #136 )
There were a few
VLen*types that were missed by the previous PR that ensured theencodemethods all returnedndarrays. In particularVLenBytesandVLenArraywere missed. This fixes that oversight by ensuring these also returnndarrays.TODO:
tox -e py37passes locallytox -e py27passes locallytox -e docspasses locally