Skip to content

Conversation

mkitti
Copy link
Contributor

@mkitti mkitti commented Aug 19, 2025

Add pcodec and zfpy to 32-bit continuous integration

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (878d2b3) to head (009d97a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #786   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         2804      2804           
=========================================
  Hits          2804      2804           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkitti
Copy link
Contributor Author

mkitti commented Aug 21, 2025

pcodec works at 4d32918

I'm going for zfpy but there is no sdist.

@mkitti mkitti force-pushed the mkitti-i386-test-pcodec branch from 8573767 to 10b1150 Compare August 22, 2025 06:22
@d-v-b
Copy link
Contributor

d-v-b commented Aug 22, 2025

this looks like quite the saga

@mkitti
Copy link
Contributor Author

mkitti commented Aug 22, 2025

Yes, quite the epic.

I think this will do for now, but I see some potential issues in the future.

The maintainace of zfpy upstream needs some attention.

@mkitti
Copy link
Contributor Author

mkitti commented Aug 22, 2025

I think this is where I would want it to be for now.

We've added pcodec and zfpy to CI under a 32-bit Linux environment. We've even figured out how to build these from source in that 32-bit environment involving Rust and C++ toolchains.

I have some suspicion that zfpy may be linking against the system numpy and using the system cython in the current configuration. That said I'm not sure if zfpy is ready to be linked against numpy 2.x.

@mkitti mkitti marked this pull request as ready for review August 22, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants