Skip to content

TestArray.KVStoreClass is not overridden in tests that inherit from TestArray #1303

Open
@d-v-b

Description

@d-v-b

The TestArray class in test_core.py defines a class attribute called KVStoreClass that is assigned to KVStore (or KVStoreV3 in the v3 version of the test class), and this value is used in just one test: test_array_init. test_array_init only references self once, to get the KVStoreClass for instantiation before creating an array with the init_array -> Array sequence.

Because none of the V2 test array classes inheriting from TestArray override KVStoreClass, and none of them override test_array_init, it seems like this test is identical for each V2 subclass of TestArray, and therefore not needed.

Is this assessment correct, or did I miss something here?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions