Skip to content

TestArray.KVStoreClass is not overridden in tests that inherit from TestArray #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-v-b opened this issue Dec 19, 2022 · 0 comments
Open

Comments

@d-v-b
Copy link
Contributor

d-v-b commented Dec 19, 2022

The TestArray class in test_core.py defines a class attribute called KVStoreClass that is assigned to KVStore (or KVStoreV3 in the v3 version of the test class), and this value is used in just one test: test_array_init. test_array_init only references self once, to get the KVStoreClass for instantiation before creating an array with the init_array -> Array sequence.

Because none of the V2 test array classes inheriting from TestArray override KVStoreClass, and none of them override test_array_init, it seems like this test is identical for each V2 subclass of TestArray, and therefore not needed.

Is this assessment correct, or did I miss something here?

@d-v-b d-v-b mentioned this issue Dec 21, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant