You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The TestArray class in test_core.py defines a class attribute called KVStoreClass that is assigned to KVStore (or KVStoreV3 in the v3 version of the test class), and this value is used in just one test: test_array_init. test_array_init only references self once, to get the KVStoreClass for instantiation before creating an array with the init_array -> Array sequence.
Because none of the V2 test array classes inheriting from TestArray override KVStoreClass, and none of them override test_array_init, it seems like this test is identical for each V2 subclass of TestArray, and therefore not needed.
Is this assessment correct, or did I miss something here?
The text was updated successfully, but these errors were encountered:
The
TestArray
class intest_core.py
defines a class attribute calledKVStoreClass
that is assigned toKVStore
(orKVStoreV3
in the v3 version of the test class), and this value is used in just one test: test_array_init.test_array_init
only referencesself
once, to get the KVStoreClass for instantiation before creating an array with theinit_array
->Array
sequence.Because none of the V2 test array classes inheriting from
TestArray
overrideKVStoreClass
, and none of them overridetest_array_init
, it seems like this test is identical for each V2 subclass ofTestArray
, and therefore not needed.Is this assessment correct, or did I miss something here?
The text was updated successfully, but these errors were encountered: