Skip to content

Additional fsspec tests #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
joshmoore opened this issue Jan 20, 2023 · 7 comments
Open
2 tasks

Additional fsspec tests #1328

joshmoore opened this issue Jan 20, 2023 · 7 comments
Labels
good-first-issue Good place to get started as a new contributor. tests

Comments

@joshmoore
Copy link
Member

  • Add test with --pre version of fsspec to detect upcoming issues
  • Add reference filesystem test possibly by depending (optionally) on tifffile

Originally posted by @joshmoore in #1324 (comment)

@joshmoore joshmoore added the good-first-issue Good place to get started as a new contributor. label Jan 20, 2023
@jakirkham
Copy link
Member

Thanks for raising Josh! Was thinking the same thing

That and/or setting up some kind of regression testing with fsspec. Something useful along these lines would be Numba's texasbbq project

@joshmoore
Copy link
Member Author

That's nice! So in this case, @jakirkham, you'd create a zarr-integration-testing repo and add in tifffile or were you thinking an fsspec-integration-testing with zarr?

cc: @cgohlke @martindurant

@AkashS20
Copy link

AkashS20 commented Feb 4, 2023

Hi, I would like to contribute to this. I'm new to open source so if you could please guide me on solving this
it will be of great help.

@forman
Copy link

forman commented Feb 10, 2023

@joshmoore @jakirkham

For example, FSMap of fsspec 2022.3.0 no longer has an attribute check (unfortunately without former deprecation), but current Zarr still uses it: https://github.com/zarr-developers/zarr-python/blob/main/zarr/storage.py#L148. @AkashS20, I guess, this is where regression testing applies, e.g., checking if fsspec interface are as expected.

Unfortunately, our latest xcube release is broken due to this:

image

EDIT

Unfortunately, our latest xcube ...

It's only broken when used used with fsspec >=2023.2.

@martindurant
Copy link
Member

fsspec' FSMap does still have check=: https://github.com/fsspec/filesystem_spec/blob/master/fsspec/mapping.py#L37
and indeed it sets mapper.check a few lines later.

Furthermore, fsspec runs one simple xarray/zarr roundtrip (with s3 local mock) as part of its "downstream" CI job, which might catch this sort of thing.

@joshmoore
Copy link
Member Author

@forman: what version of Zarr?

@martindurant: any idea on what the cause might be there then?

@martindurant
Copy link
Member

No, I don't know, and I don't see a failure on xcube either :|

joshmoore added a commit to joshmoore/ome-zarr-py that referenced this issue Feb 20, 2023
This build was put in place by the Zarr team in order to check
for potential issues in downstream projects after PRs have been
merged. For some reason, it is now aborting with little to no
logging. In zarr-developers/zarr-python#1328
the `texasbbq` package from Numba has been suggested for a similar
purpose. This workflow might could be rewritten using such a tool.
@dstansby dstansby added the tests label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good place to get started as a new contributor. tests
Projects
None yet
Development

No branches or pull requests

6 participants