pre-commit-ci bot

[d-v-b]

over in #1459 I'm trying to change the pre-commit configuration without styling the code, because I want that to be a separate PR, as per the suggestion here. The logic of that suggestion was to separate the styling configuration changes (which should be attributed to me in git blame) from the styling itself, which will touch the entire codebase and probably not be attributed to anyone in git blame.

However, this project now has a bot that automatically applies the pre-commit hooks to pull requests, even for files that haven't been committed. See f1d1372 Because of this bot, it's impossible to do separate PRs for this styling change.

What is the argument for using this bot? I feel like the styling / linting stuff should be part of the checks PRs must pass rather than changes that are automatically applied to PRs.

[Saransh-cpp]

You should be able to use [pre-commit.ci skip] in your commit message to stop the bot from acting on a commit.

[d-v-b]

You should be able to use [pre-commit.ci skip] in your commit message to stop the bot from acting on a commit.

That's good to know! It looks like this is documented in more detail here: https://pre-commit.ci/

However, I'm still not sure why this bot exists, rather than making linting part of the checks for a PR

[rabernat]

I am not a fan of having the bot make commits. I feel like this creates friction in the developer workflow. I'd be in favor of changing the configuration. Thoughts @joshmoore?

[joshmoore]

I don't have a strong feeling either way, i.e. there are pros and cons of both. I think this was mostly because the kind folks that were working on linting during gsoc & outreachy were in favor, but I agree that this should most importantly work for active maintainers. As long as it gets fixed per PR rather than breaking things deeper in the release process, I'll be happy.

[jhamman]

What is the argument for using this bot? I feel like the styling / linting stuff should be part of the checks PRs must pass rather than changes that are automatically applied to PRs.

My understanding is that this is the state we've landed on. Closing but reopen if there's more to do here.