-
-
Notifications
You must be signed in to change notification settings - Fork 329
style: add pre-commit configs for ruff and black, round 3 #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1457 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 15026 15026
=========================================
Hits 15026 15026
|
looks like i'm fighting with the pre-commit bot... |
Hi @d-v-b I think it might be worth to remove the formatting commit from blame https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view |
@ap-- I think that's a good idea -- I will open a new PR for just the pre-commit config changes, then a separate PR for applying them to the codebase, with that commit made "blameless" Closing this PR in favor of the strategy outlined above. |
This PR adds pre-commit configuration for ruff and black. It also applies those linters to the zarr-python codebase.
TODO: