-
-
Notifications
You must be signed in to change notification settings - Fork 329
add ruff and black to precommit #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 36 35 -1
Lines 14744 14404 -340
==========================================
- Hits 14744 14404 -340
|
…into precommit_formatting_2
Any objections to getting this in sooner rather than later? Every change to |
Yes. #1305 (comment) Or rather, what's the plan on updating the existing PRs? |
Which PRs do you mean (which are the sharding PRs, and which are the "existing PRs")? In the case of sharding, is there more coming in besides #1096, which this PR builds on? |
#1111 is the other open sharding PR which has now been re-written a couple of times. Existing PRs are just all the other open ones. But if I exclude yours and only look at the last year, that's 23: |
I'm fine with updating this PR every time something new is added to |
I wonder if this would help you, @d-v-b: https://github.blog/changelog/2023-02-08-pull-request-merge-queue-public-beta/ 😄 |
…into precommit_formatting_2
closing in favor of #1457 |
Second attempt to add ruff and black to precommit, this time with a non-cursed git history. Supersedes #1321.
TODO: