Skip to content

Precommit formatting #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

Precommit formatting #1321

wants to merge 19 commits into from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jan 16, 2023

  • adds ruff and black to precommit
  • removes flake8 from precommit
  • moves codespell configuration to pyproject.toml
  • code changes required to appease the linters
  • Add unit tests and/or doctests in docstrings (N/A)
  • Add docstrings and API docs for any new/modified user-facing classes and functions (N/A)
  • New/modified features documented in docs/tutorial.rst (N/A)
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

d-v-b and others added 19 commits December 15, 2022 15:57
@d-v-b
add attrs kwarg to array and group initialization routines
4a51f81
@d-v-b
add attrs kwarg to additional wrappers for creation functions
7470b63
@d-v-b
split out array and group meta key inference functionality
356b038
@d-v-b
add release note
a963bb3
@d-v-b
add attrs kwarg to more (all)? instances of init_arrays, add types, a…
87174c1 
…nd blacken
@d-v-b
Merge branch 'main' into attrs_kwarg
bb59a4e
@d-v-b
use Attributes.put instead of update for initializing attributes, and…
d548044 
… more types
@d-v-b
Merge branch 'attrs_kwarg' of https://github.com/d-v-b/zarr-python in…
6606bca 
…to attrs_kwarg
@d-v-b
fix types
cb66c0e
@d-v-b
fix ambitious type hints
39f2b35
@d-v-b
Merge branch 'main' of https://github.com/zarr-developers/zarr-python
257bf3f
@d-v-b
merge from upstream
c12310d
@d-v-b
push unsaved merges
923fb48
@d-v-b
revert to upstream main
99b04b6
@d-v-b
add ruff to precommit
f1d1db6
@d-v-b
add black to precommit
bcbd6a7
@d-v-b
linting
8eddcac
@d-v-b
add release notes
3051b39
@pre-commit-ci
style: pre-commit fixes
2ff320d
@d-v-b
Copy link
Contributor Author

d-v-b commented Jan 16, 2023

commit history looks gnarly -- sorry about that. I accidentally put some commits from a feature branch into my main branch, then reverted at 99b04b6

@d-v-b d-v-b mentioned this pull request Jan 16, 2023
Closed
6 tasks
@codecov
Copy link

codecov bot commented Jan 16, 2023 •
edited
Loading

Codecov Report

Merging #1321 (2ff320d) into main (385b5d3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main     #1321    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           35        35            
  Lines        14388     14126   -262     
==========================================
- Hits         14388     14126   -262
Impacted Files Coverage Δ
zarr/tests/test_core.py 100.00% <ø> (ø)
zarr/tests/test_storage.py 100.00% <ø> (ø)
zarr/__init__.py 100.00% <100.00%> (ø)
zarr/_storage/absstore.py 100.00% <100.00%> (ø)
zarr/_storage/store.py 100.00% <100.00%> (ø)
zarr/_storage/v3.py 100.00% <100.00%> (ø)
zarr/attrs.py 100.00% <100.00%> (ø)
zarr/convenience.py 100.00% <100.00%> (ø)
zarr/core.py 100.00% <100.00%> (ø)
zarr/creation.py 100.00% <100.00%> (ø)
... and 26 more

joshmoore
joshmoore reviewed Jan 17, 2023
View reviewed changes
.github/workflows/needs_release_notes.yml
@@ -5,7 +5,6 @@ on:

jobs:
triage:
if: ${{ github.event.pull_request.user.login != 'dependabot[bot]' }} && ${{ github.event.pull_request.user.login != 'pre-commit-ci[bot]' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this get dropped?

joshmoore
joshmoore reviewed Jan 17, 2023
View reviewed changes
.github/workflows/releases.yml
@@ -64,7 +64,7 @@ jobs:
with:
name: releases
path: dist
- uses: pypa/[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think this is reverting things that have hit the mainline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, and I'm not sure why this is happening -- possibly we've reached the limits of my experience with git. When I run git pull upstream main, git claims everything is up to date, but clearly there's lots of recent commits on mainline that are missing from this PR. Any advice?

@d-v-b d-v-b mentioned this pull request Jan 18, 2023
Closed
6 tasks
@d-v-b
Copy link
Contributor Author

d-v-b commented Jan 18, 2023

closing in favor of #1323

@d-v-b d-v-b closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmoore joshmoore joshmoore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-v-b @joshmoore