Skip to content

[v3] LocalStore__eq__ #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
d-v-b opened this issue Apr 5, 2024 · 2 comments
Closed

[v3] LocalStore__eq__ #1744

d-v-b opened this issue Apr 5, 2024 · 2 comments
Labels
good-first-issue Good place to get started as a new contributor. help wanted Issue could use help from someone with familiarity on the topic
Milestone
3.0.0

Comments

@d-v-b
Copy link
Contributor

d-v-b commented Apr 5, 2024

Right now, LocalStore('tmp') == LocalStore('tmp') is False. I think this should evaluate to True; fixing it requires implementing __eq__ on LocalStore.

This would be good issue for anyone interested in working on v3 stuff.
@d-v-b d-v-b added help wanted Issue could use help from someone with familiarity on the topic good-first-issue Good place to get started as a new contributor. V3 labels Apr 5, 2024
@d-v-b
Copy link
Contributor Author

d-v-b commented Apr 5, 2024

LocalStore is in the v3 branch

@jhamman jhamman moved this to Todo in Zarr-Python - 3.0 Apr 5, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 5, 2024
Charoula-Kyriakides added a commit to Charoula-Kyriakides/zarr-python that referenced this issue Apr 13, 2024
@Charoula-Kyriakides
LocalStore__eq__ zarr-developers#1744
932329f 
Fix equality comparison in LocalStore class by implementing __eq__ method
d-v-b added a commit that referenced this issue Apr 21, 2024
@Charoula-Kyriakides @d-v-b
implement __eq__ for LocalStore (#1792)
136daec 
* LocalStore__eq__ #1744

Fix equality comparison in LocalStore class by implementing __eq__ method

* Update src/zarr/v3/store/local.py

Changed 'LocalStore' to object in __eq__

Co-authored-by: Davis Bennett <[email protected]>

---------

Co-authored-by: Davis Bennett <[email protected]>
@jhamman jhamman modified the milestones: 3.0.0.alpha, 3.0.0 May 24, 2024
@jhamman
Copy link
Member

jhamman commented Jul 2, 2024

closed by #1792

@jhamman jhamman closed this as completed Jul 2, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Zarr-Python - 3.0 Jul 2, 2024
@jhamman jhamman removed the status in Zarr-Python - 3.0 Jul 2, 2024
@jhamman jhamman moved this to Done in Zarr-Python - 3.0 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good place to get started as a new contributor. help wanted Issue could use help from someone with familiarity on the topic
Projects
Zarr-Python - 3.0
Status: Done
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@jhamman @d-v-b