Skip to content

MsgPack codec is broken for array of bytes objects #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alimanfoo opened this issue Nov 6, 2018 · 2 comments · Fixed by #352
Closed

MsgPack codec is broken for array of bytes objects #324

alimanfoo opened this issue Nov 6, 2018 · 2 comments · Fixed by #352
Milestone

Comments

@alimanfoo
Copy link
Member

Currently the tests involving the msgpack codec expect broken behaviour where the codec converts an array of bytes objects to an array of str (unicode) objects. Relevant line of code is here:

https://github.com/zarr-developers/zarr/blob/a4d5656e3042216308b03ab7514567139d4004fc/zarr/tests/test_core.py#L985

This is causing problems elsewhere, e.g., #278 (comment).

@jakirkham
Copy link
Member

Went ahead and added this to the v2.3 milestone so we can track it. Though if we decide to punt on it, we can always re-milestone it.

@alimanfoo
Copy link
Member Author

alimanfoo commented Nov 21, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants