raise an error if create_dataset's dimension_separator is inconsistent with the provided store #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 28 28
Lines 10433 10442 +9
=======================================
+ Hits 10427 10436 +9
Misses 6 6
|
|
Nice! This might be the better idea for #722, rather than trying to propagate the value down into wrapped store. |
|
Released as 2.8.1 |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Description
While working on the zarr_implementations repository, at one point I generated data with
create_datasetusingdimension_separator='/', but with the default FSStore which has a key_separator of '.'. This did not result in any warning, but generated a flat storage format despite the specification ofdimension_separator. This PR is intended to prevent this by checking for consistency between a store's dimension separator and the one passed as an argument tocreate_dataset.TODO: