-
-
Notifications
You must be signed in to change notification settings - Fork 330
Versioning Releases wiith Rever #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for looking into this, @GbotemiB. Can you update the description with the steps that someone would take to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I am not a maintainer. You can ignore my reviews if the maintainers approve of this. I generally like reading others' code and working on open-source research software 😄)
$VERSION_BUMP_PATTERNS = [ # These note where/how to find the version numbers | ||
('zarr/version.py', r'__version__\s*=.*', "__version__ = '$VERSION'"), | ||
('setup.py', r'version\s*=.*,', "version='$VERSION',") | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, is this manually bumping Zarr's version? Remember, Zarr uses VCS to generate versions. This means that -
zarr/version.py
technically does not exist. It is an autogenerated file, which is generated bysetuptools_scm
using thegit
tags available in Zarr'sgit
repository. We should not be editing this autogenerated file manually. Whenever a newgit
tag is created inZarr
,setuptools_scm
automatically picks it up and bumpsZarr
's version.setup.py
specifies using a VCS version using theuse_scm_version
argument insetup
. Hence, there are no "version" variables that have to be updated insetup.py
.
TL;DR: We should not be manually bumping Zarr's version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the review.
👍 for @Saransh-cpp's review. |
Since SCM manages the version on zarr. It wont be necessary to use rever to bump the versions. But if there is a need to use rever to bump versions, I have the steps outlined here. |
Thanks for the work on this @GbotemiB! 🙏 Would it be possible to incorporate this into our GitHub Actions release process? Also do you think this would be possible to add to Numcodecs? |
Re-ver has support for Github releases. I will look into this. I will look into bringing it to Numcodecs |
Definitely we use rever in conda-forge. Ideally we would include this as a step in GitHub Actions (maybe after this one?). Maybe we would change the trigger (like using a bot command or issue). There's also some discussion about options for changelog generation in issue ( #829 ). From it a few things (including rever's new workflow) come up. Some of the others are: |
@jakirkham: do you mean |
Sorry for missing this. What I mean is we can basically do a release from the GitHub UI today. That's incredibly valuable as that keeps things easy for others wanting to release. Think any changes we make to the release log process, should preserve that functionality. Otherwise we are merely trading one pain point for another (simpler changelog management for harder release process) |
This has unfortunately gone stale. Will it be revived or should we close this? |
This PR contains creating/managing version num on zarr with rever.
Steps:
after making changes in development. To update the version with rever, simply run the following commands in root directory.
$ rever setup
$ rever
<the version number>
TODO:
Fixes #829