Skip to content

Ensure zarr.group uses writable mode #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

Swordcat
Copy link
Contributor

@Swordcat Swordcat commented Feb 22, 2023

Closes #1352 and #1353

cc @flamingbear @rabernat

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #1354 (a350f33) into main (d7d8815) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1354   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines        14768     14775    +7     
=========================================
+ Hits         14768     14775    +7     
Impacted Files Coverage Δ
zarr/hierarchy.py 100.00% <100.00%> (ø)
zarr/tests/test_hierarchy.py 100.00% <100.00%> (ø)

Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! We truly appreciate this quick and clean PR. 🙏

Edit: feel free to credit yourself in the release notes.

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Feb 23, 2023
@rabernat rabernat merged commit 5ece3e6 into zarr-developers:main Feb 23, 2023
@rabernat
Copy link
Contributor

Thanks so much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression using fsspec.mapping.FSMap object to initialize a store
3 participants