-
-
Notifications
You must be signed in to change notification settings - Fork 329
Support Block (Chunk) Indexing #1428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 37 37
Lines 14866 15017 +151
==========================================
+ Hits 14866 15017 +151
|
add block selection to array tests
Yes please, and update your comments of |
Done! Seems like all the CI passed too. |
@joshmoore ready to merge? |
In general, this looks really well done. I'd still ping a few daskanistas (daskonauts?) for some feedback. cc: @jrbourbeau @jni but of course others welcome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great new feature.
Closes #518, #543, #545, #991.
This feature has been requested many times.
This adds the basic functionality of Dask's
dask.array.Array.blocks
indexing.I explained the implementation in detail in #991. Please see details there.
This PR implements #991 and adds tests, tutorial, and docs.
This does allow integer and slice (with step of 1) block indexing, or a mix of the two, for Zarr arrays.
QUESTION
TODO: