Skip to content

Disallow implicit re-exports #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2024
Merged

Disallow implicit re-exports #1908

merged 3 commits into from
May 31, 2024

Conversation

dstansby
Copy link
Contributor

Another part of #1783. Also cleans up ignoring the v2 code in mypy.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@dstansby dstansby mentioned this pull request May 24, 2024
Closed
16 tasks
@jhamman jhamman merged commit 9ad01f1 into zarr-developers:v3 May 31, 2024
18 checks passed
@dstansby dstansby deleted the typing-no-implicit-reexports branch May 31, 2024 21:59
dstansby added a commit to dstansby/zarr-python that referenced this pull request May 31, 2024
@dstansby
Disallow implicit re-exports (zarr-developers#1908)
7265f00 
* No implict reexports

* Clean up v2 mypy ignores
@jhamman jhamman added this to the 3.0.0.alpha milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
types
Projects
None yet
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @jhamman