-
-
Notifications
You must be signed in to change notification settings - Fork 329
Stateful store tests #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stateful store tests #2070
Conversation
Co-authored-by: Deepak Cherian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work, Emma!
👏🏾 👏🏾 👏🏾
thanks @dcherian ! thanks for all your help, fun to work with you and Seba on this! |
* v3: [v3] reorganize package - move most modules to zarr.core (zarr-developers#2072)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super work @e-marshall! I have a bunch of comments on the Store wrapper -- none of them major.
Co-authored-by: Joe Hamman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last set of small comments but I'm approving this as is. 🙌
Co-authored-by: Joe Hamman <[email protected]>
thanks @jhamman ! |
Can we merge so that one might add |
I am working on getting that PR updated and ready |
Right, I meant that we could merge this PR so that we can add |
This is a PR that implements stateful tests for Zarr MemoryStores.
TODO items below:
TODO: