Skip to content

Generalize stateful store test #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 27, 2024
Merged

Generalize stateful store test #2202

merged 9 commits into from
Sep 27, 2024

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Sep 18, 2024 •
edited
Loading

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

cc @e-marshall

@dcherian dcherian force-pushed the generalize-stateful-store branch from c7adc3f to 7e8c1c2 Compare September 18, 2024 04:06
@dcherian dcherian mentioned this pull request Sep 21, 2024
Closed
@dcherian
Copy link
Contributor Author

This can be merged. It lets external stores plug in to the test

dstansby
dstansby reviewed Sep 21, 2024
View reviewed changes
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a few minor suggestions for slightly clearer code

@dcherian
Merge branch 'v3' into generalize-stateful-store
ad3df88 
* v3:
  chore: update pre-commit hooks (zarr-developers#2222)
  fix: validate v3 dtypes when loading/creating v3 metadata (zarr-developers#2209)
  fix typo in store integration test (zarr-developers#2223)
  Basic Zarr-python 2.x compatibility changes (zarr-developers#2098)
  Make Group.arrays, groups compatible with v2 (zarr-developers#2213)
  Typing fixes to test_indexing (zarr-developers#2193)
  Default to RemoteStore for fsspec URIs (zarr-developers#2198)
  Make MemoryStore serialiazable (zarr-developers#2204)
  [v3] Implement Group methods for empty, full, ones, and zeros (zarr-developers#2210)
  implement `store.list_prefix` and `store._set_many` (zarr-developers#2064)
  Fixed codec for v2 data with no fill value (zarr-developers#2207)
@dcherian
Address feedback
ae42bff
@dcherian dcherian force-pushed the generalize-stateful-store branch from 783f916 to ae42bff Compare September 24, 2024 03:40
@dcherian
Merge branch 'v3' into generalize-stateful-store
80a83a1 
* v3:
  remove outdated v2 source code and tests from v3 branch (zarr-developers#2182)
  Fix/empty listdir (zarr-developers#2225)
  Bump pypa/gh-action-pypi-publish in the actions group (zarr-developers#2219)
  Added Attributes.asdict (zarr-developers#2221)
@dcherian
Limit binary size, and range for key_ranges
27efef0
@dcherian dcherian mentioned this pull request Sep 24, 2024
Merged
6 tasks
@dcherian
Merge branch 'v3' into generalize-stateful-store
ae3bca5 
* v3: (21 commits)
  Default zarr.open to open_group if shape is not provided (zarr-developers#2158)
  feat: metadata-only support for storage transformers metadata (zarr-developers#2180)
  fix(async): set default concurrency to 10 tasks (zarr-developers#2256)
  chore(deps): drop support for python 3.10 and numpy 1.24 (zarr-developers#2217)
  feature(store): add LoggingStore wrapper (zarr-developers#2231)
  Apply assorted ruff/flake8-simplify rules (SIM) (zarr-developers#2259)
  Add array storage helpers (zarr-developers#2065)
  Apply ruff/flake8-annotations rule ANN204 (zarr-developers#2258)
  No need to run DeepSource any more - we use ruff (zarr-developers#2261)
  Remove unnecessary lambda expression (zarr-developers#2260)
  Enforce ruff/flake8-comprehensions rules (C4) (zarr-developers#2239)
  Use `map(str, *)` in `test_accessed_chunks` (zarr-developers#2229)
  Replace Gitter with Zulip (zarr-developers#2254)
  Enforce ruff/flake8-pytest-style rules (PT) (zarr-developers#2236)
  Fix multiple identical imports (zarr-developers#2241)
  Enforce ruff/flake8-return rules (RET) (zarr-developers#2237)
  Enforce ruff/flynt rules (FLY) (zarr-developers#2240)
  Fix fill_value handling for complex dtypes (zarr-developers#2200)
  Update V2 codec pipeline to use concrete classes (zarr-developers#2244)
  Apply and enforce more ruff rules (zarr-developers#2053)
  ...
@dcherian
small cleanup
6e9eeb1
@dcherian dcherian force-pushed the generalize-stateful-store branch from c5e31fb to 6e9eeb1 Compare September 27, 2024 16:43
@dcherian
Copy link
Contributor Author

Still fails for LocalStore, will debug later.

@dcherian dcherian merged commit b6350a1 into zarr-developers:v3 Sep 27, 2024
20 checks passed
@dcherian dcherian deleted the generalize-stateful-store branch September 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby left review comments

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcherian @jhamman @dstansby