Skip to content

[v2] Remove print statement from structured dtype metadata parsing #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

tasansal
Copy link
Contributor

@tasansal tasansal commented Apr 22, 2025

In #2802 a print statement was added to V2 metadata parsing for structured arrays. This is most likely a debugging statement. Removing this because it prints every time we open a group or array with structured arrays.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 22, 2025
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@tasansal tasansal changed the title [v2] Remove print statement from structured dtype metadata [v2] Remove print statement from structured dtype metadata parsing Apr 22, 2025
@tasansal
Copy link
Contributor Author

I am a little bit confused why codecov went down after removing a print statement :D

@tasansal
Copy link
Contributor Author

@d-v-b some test and codecov seems to be failing, is that coming from main?

@d-v-b
Copy link
Contributor

d-v-b commented Apr 22, 2025

i think coverage is not accurate until all the tests are done, and it looks like 1 flaky test failed. I'm re-running it.

@joshmoore
Copy link
Member

I re-ran as well. Can I propose we ignore and roll into a super quick 3.0.8? (only other commits so far are improvements to docstrings)

@d-v-b
Copy link
Contributor

d-v-b commented Apr 24, 2025

I'm going to merge this as-is, we can solve the mystery of the flaky test elsewhere

@d-v-b d-v-b merged commit 5f4aeb4 into zarr-developers:main Apr 24, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants