Only warn if opening writeable store with mode='r' #3155
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-v-b
approved these changes
Jun 19, 2025
|
I still prefer the approach suggested in #3068 (comment) to create a read-only copy because it solves the bug mentioned in #3147. I sketched out this approach in 5b83732 but did not open a PR yet because it builds off the functionality in #3138. |
6 tasks
@dstansby if you have time could you please take a look at #3156 as an alternative solution? |
|
👍 sounds good - will put this in draft, and we can close if/when the other PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See much discussion in #3068 - instead of erroring, this just warns now. ping @maxrjones