-
-
Notifications
You must be signed in to change notification settings - Fork 361
Add v2 and v3 metadata support to codecs #3332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
this is now in a phase where I would really appreciate eyes from @zarr-developers/python-core-devs. The goal of this PR is twofold:
In this PR, when a user shows up with This PR also adds typeddict classes for the v2 and v3 form of each codec, which was laborious but IMO worth it for type safety. If you have time, please look this over and / or test this on your v2 -> v3 workloads. That would be extremely helpful. I think these changes are on the same scale as the data type changes, so this requires a lot of finesse and potentially follow-up PRs. |
This PR will give each codec a v2 and v3 JSON de/serialization routines.
depends on #3318