Skip to content

Conversation

@d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Aug 6, 2025

This PR excludes some unreachable lines of code from test coverage, and adds tests for a few missing routines in zarr.api.asynchronous.

I put those missing tests in a new directory to ensure that the tests are found in a location that matches the layout of the source code (unlike our current api tests). Eventually we should move all of the tests in tests/test_api.py to tests/test_api/test_asynchronous.py or tests/test_api/test_synchronous.py.

I did not add a test for api.asynchronous.open_like because it's broken. see #3352 .

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Aug 6, 2025
@d-v-b d-v-b requested a review from a team August 6, 2025 12:32
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.66%. Comparing base (4b26501) to head (14e5573).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
+ Coverage   94.55%   94.66%   +0.10%     
==========================================
  Files          79       79              
  Lines        9447     9444       -3     
==========================================
+ Hits         8933     8940       +7     
+ Misses        514      504      -10     
Files with missing lines Coverage Δ
src/zarr/abc/codec.py 98.71% <ø> (+3.65%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b d-v-b enabled auto-merge (squash) August 19, 2025 18:56
@d-v-b d-v-b merged commit 6a546d6 into zarr-developers:main Aug 19, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants