WIP: Include some tests of store equality

zarr/storage.py

@@ -569,8 +569,8 @@ def __contains__(self, item):
     def __eq__(self, other):
         return (
             isinstance(other, DictStore) and
-            self.root == other.root and
-            self.cls == other.cls
+            self.cls == other.cls and
+            self.root is other.root
         )
 
     def keys(self):
@@ -1843,6 +1843,13 @@ def _invalidate_value(self, key):
             value = self._values_cache.pop(key)
             self._current_size -= buffer_size(value)
 
+    def __eq__(self, other):
+        return (
+            isinstance(other, LRUStoreCache) and
+            self._store is other._store and
+            self._values_cache is other._values_cache
+        )
+
     def __getitem__(self, key):
         try:
             # first try to obtain the value from the cache
@@ -1968,6 +1975,14 @@ def close(self):
         self.cursor.close()
         self.db.close()
 
+    def __eq__(self, other):
+        return (
+            isinstance(other, SQLiteStore) and
+            self.path == other.path and
+            self.kwargs == other.kwargs and
+            self.db == other.db
+        )
+
     def __getitem__(self, key):
         value = self.cursor.execute('SELECT v FROM zarr WHERE (k = ?)', (key,))
         for v, in value:

zarr/tests/test_storage.py

@@ -119,6 +119,35 @@ def test_writeable_values(self):
         store['foo3'] = array.array('B', b'bar')
         store['foo4'] = np.frombuffer(b'bar', dtype='u1')
 
+    def test_compare_eq(self):
+        store1 = self.create_store()
+        store2 = self.create_store()
+
+        assert store1 == store1
+        store2['foo'] = b'abcde'
+        assert store2 == store2
+
+        store1 = self.create_store()
+        store2 = self.create_store()
+
+        store1['foo'] = b'abcde'
+        store2['foo'] = b'abcde'
+        assert store1 != store2
+
+        store1 = self.create_store()
+        store2 = self.create_store()
+
+        store1['foo'] = b'abcde'
+        store2['baz'] = b'abcde'
+        assert store1 != store2
+
+        store1 = self.create_store()
+        store2 = self.create_store()
+
+        store1['foo'] = b'abcde'
+        store2['foo'] = b'uvwxy'
+        assert store1 != store2
+
     def test_update(self):
         store = self.create_store()
         assert 'foo' not in store