-
-
Notifications
You must be signed in to change notification settings - Fork 329
Fixing permissions for files inside a ZipStore #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jakirkham
merged 10 commits into
zarr-developers:master
from
raphaeldussin:zipstore_perm_fix
Jan 6, 2020
Merged
Fixing permissions for files inside a ZipStore #517
jakirkham
merged 10 commits into
zarr-developers:master
from
raphaeldussin:zipstore_perm_fix
Jan 6, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon into zipstore_perm_fix
* special code for string is unnecessary as zarr will only work with bytes
add test for permissions
Hello @raphaeldussin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-12-30 21:12:22 UTC |
permissions for directories differ between platforms
* decreases coverage (travis)
cannot get tox working but works with docs/Makefile |
Thanks @raphaeldussin! 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default zipfile.writestr write files with permissions 600 when called with a filename.
These permissions are too restrictive for ZipStore to be shared with other users. In order to
fix the problem, I pass zipfile.writestr a zipfile.ZipInfo object in which I have set more open
permissions. Fixes #505
TODO:
tox -e docs
)