Skip to content

Fixing permissions for files inside a ZipStore #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 6, 2020

Conversation

raphaeldussin
Copy link
Contributor

@raphaeldussin raphaeldussin commented Nov 19, 2019

By default zipfile.writestr write files with permissions 600 when called with a filename.
These permissions are too restrictive for ZipStore to be shared with other users. In order to
fix the problem, I pass zipfile.writestr a zipfile.ZipInfo object in which I have set more open
permissions. Fixes #505

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • Docs build locally (e.g., run tox -e docs)
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

Raphael Dussin and others added 5 commits November 18, 2019 18:26
@pep8speaks
Copy link

pep8speaks commented Nov 19, 2019

Hello @raphaeldussin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-30 21:12:22 UTC

permissions for directories differ between platforms
* decreases coverage (travis)
@raphaeldussin
Copy link
Contributor Author

raphaeldussin commented Nov 20, 2019

cannot get tox working but works with docs/Makefile

@jakirkham jakirkham merged commit 4992c0c into zarr-developers:master Jan 6, 2020
@jakirkham
Copy link
Member

Thanks @raphaeldussin! 😀

@Carreau Carreau added this to the v2.4 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

permission problem in zarr.ZipStore
4 participants