Add StoreV3 support to Array (zarr v3 support part 3) #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the StoreV3 class and create v3 versions of most existing stores Add a test_storage_v3.py with test classes inheriting from their v2 counterparts. Only a subset of methods involving differences in v3 behavior were overridden.
Codecov Report
@@ Coverage Diff @@
## master #895 +/- ##
==========================================
- Coverage 99.94% 98.22% -1.72%
==========================================
Files 32 34 +2
Lines 11216 13029 +1813
==========================================
+ Hits 11210 12798 +1588
- Misses 6 231 +225
|
6 tasks
grlee77
force-pushed
the
v3-store-part3
branch
from
74369a4 to
af405f5
Compare
grlee77
force-pushed
the
v3-store-part3
branch
from
af405f5 to
116fd6a
Compare
zarr_version should not be in the array metadata, only the base store metadata compressor should be absent when there is no compression
classmethods adapted from zarrita code
grlee77
force-pushed
the
v3-store-part3
branch
from
116fd6a to
7e23438
Compare
avoid pytest error about missing fixture fix flake8 error related to zarr_version fixture
update hexdigests
grlee77
force-pushed
the
v3-store-part3
branch
from
7e23438 to
5040119
Compare
|
closing, these commits along with additional fixes and tests are incorporated in #898 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #894, adding StoreV3 support to the core Array object.
For the tests, the primary difference is that the V3 base test class inherits from the existing
TestArrayWithPathinstead ofTestArraysince specifying the path is required for v3. Mostly it is thecreate_arrayandhex_digestmethods that needed to be overridden.TODO: