Skip to content

Add numpy encoder class for json.dumps #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2022

Conversation

ericpre
Copy link
Contributor

@ericpre ericpre commented Jan 11, 2022

Fix #697.

TODO:

  • Add unit tests and/or doctests in docstrings
  • [n/a] Add docstrings and API docs for any new/modified user-facing classes and functions
  • [n/a] New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@pep8speaks
Copy link

pep8speaks commented Jan 11, 2022

Hello @ericpre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-15 08:58:20 UTC

@joshmoore
Copy link
Member

Thanks, @ericpre. I've launched the GH workflows for testing. (Manual intervention is only needed on your first PR ;) )

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #933 (7cc40c3) into master (18abb19) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #933   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          33       33           
  Lines       13622    13638   +16     
=======================================
+ Hits        13616    13632   +16     
  Misses          6        6           
Impacted Files Coverage Δ
zarr/tests/test_creation.py 100.00% <100.00%> (ø)
zarr/tests/test_util.py 100.00% <100.00%> (ø)
zarr/util.py 100.00% <100.00%> (ø)

@ericpre ericpre force-pushed the json_dump_numpy_type branch from b726e0d to 3cff8da Compare January 11, 2022 13:26
@ericpre ericpre force-pushed the json_dump_numpy_type branch from 3cff8da to 76c9125 Compare January 11, 2022 13:46
@ericpre ericpre force-pushed the json_dump_numpy_type branch from 30a5797 to fd37e1c Compare January 19, 2022 11:47
@joshmoore joshmoore requested a review from jakirkham January 26, 2022 10:18
@ericpre
Copy link
Contributor Author

ericpre commented Feb 3, 2022

@jakirkham, @joshmoore, does it look good to you now? :)

@joshmoore
Copy link
Member

Now green after upgrading the main branch to match 2.11.

@ericpre
Copy link
Contributor Author

ericpre commented Mar 16, 2022

@joshmoore, @jakirkham, would it be possible to get this PR reviewed again please? Thanks!

@joshmoore
Copy link
Member

I've relaunched the build. I don't know of any other existing solution and as this is a pure addition, 👍 from my side. @jakirkham ?

@ericpre
Copy link
Contributor Author

ericpre commented Apr 14, 2022

Ping @jakirkham.

@jakirkham
Copy link
Member

Sorry for the very slow reply. This seems reasonable. Let's get it in.

@joshmoore
Copy link
Member

Thanks, @jakirkham! @ericpre: sorry for the wait. Do you want to push a blurb to https://github.com/zarr-developers/zarr-python/blob/master/docs/release.rst, then we'll get this merged? The only heads up is that 2.11 releases are currently slightly in limbo while we work on #1007 but that shouldn't take too long.

@ericpre
Copy link
Contributor Author

ericpre commented Apr 15, 2022

Thanks, @jakirkham! @ericpre: sorry for the wait. Do you want to push a blurb to https://github.com/zarr-developers/zarr-python/blob/master/docs/release.rst, then we'll get this merged?

Ok, done!

@joshmoore
Copy link
Member

Thanks, @ericpre! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumPy integers not accepted in chunks argument to zarr.zeros
4 participants