-
-
Notifications
You must be signed in to change notification settings - Fork 329
Add numpy encoder class for json.dumps #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numpy encoder class for json.dumps #933
Conversation
Thanks, @ericpre. I've launched the GH workflows for testing. (Manual intervention is only needed on your first PR ;) ) |
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 33 33
Lines 13622 13638 +16
=======================================
+ Hits 13616 13632 +16
Misses 6 6
|
b726e0d
to
3cff8da
Compare
3cff8da
to
76c9125
Compare
30a5797
to
fd37e1c
Compare
@jakirkham, @joshmoore, does it look good to you now? :) |
Now green after upgrading the main branch to match 2.11. |
@joshmoore, @jakirkham, would it be possible to get this PR reviewed again please? Thanks! |
I've relaunched the build. I don't know of any other existing solution and as this is a pure addition, 👍 from my side. @jakirkham ? |
Ping @jakirkham. |
Sorry for the very slow reply. This seems reasonable. Let's get it in. |
Thanks, @jakirkham! @ericpre: sorry for the wait. Do you want to push a blurb to https://github.com/zarr-developers/zarr-python/blob/master/docs/release.rst, then we'll get this merged? The only heads up is that 2.11 releases are currently slightly in limbo while we work on #1007 but that shouldn't take too long. |
Ok, done! |
Thanks, @ericpre! 🎉 |
Fix #697.
TODO: