Skip to content

Conversation

@EtherZa
Copy link
Contributor

@EtherZa EtherZa commented Dec 11, 2024

Correlation filters are more efficient then SQL filters and are the preferred way to implement filtering when the features of SQL rule filters are not required.

mbb.Consume<SomeMessage>(x => x
      .Topic("some-topic")
      .WithConsumer<SomeMessageConsumer>()
      .SubscriptionName("some-service")
      .SubscriptionCorrelationFilter(correlationId: "some-correlation-id", contentType: "application/json")
      .CreateTopicOptions((options) =>
      {
         options.RequiresDuplicateDetection = false;
      })
   );

@zarusz
Copy link
Owner

zarusz commented Dec 11, 2024

@EtherZa Do you need this in v2 (current master)?
I would love to put new features in release/v3 branch for the upcoming release.

Good job on the feature!

@EtherZa EtherZa force-pushed the feature/349-coreelation-filters branch from 2610885 to 30c925f Compare December 12, 2024 05:27
@EtherZa
Copy link
Contributor Author

EtherZa commented Dec 12, 2024

@EtherZa Do you need this in v2 (current master)? I would love to put new features in release/v3 branch for the upcoming release.

Good job on the feature!

Thanks! It's not something that I am in desperate need of right now -I have rebased the change on release/v3.

Please let me know if would like anything else tweaked.

@EtherZa
Copy link
Contributor Author

EtherZa commented Dec 12, 2024

@zarusz It looks like there may be a missing/misconfigured secret in the build pipeline for Amazon SQS.

@zarusz zarusz changed the base branch from master to release/v3 December 12, 2024 16:58
@sonarqubecloud
Copy link

@zarusz zarusz merged commit a7d2ac1 into zarusz:release/v3 Dec 12, 2024
3 checks passed
This was referenced Dec 12, 2024
@EtherZa EtherZa deleted the feature/349-coreelation-filters branch December 29, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants