[Host.RabbitMQ] Improve Validation and Default Exchange Handling #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxNau
changed the title
MaxNau
force-pushed
the
feature/rabbitmq-default-exchange
branch
4 times, most recently
from
8334b0a to
a27317f
Compare
Owner
|
Hey @MaxNau — thanks for the contribution! You’re on the right track. Could you also:
|
MaxNau
force-pushed
the
feature/rabbitmq-default-exchange
branch
from
e59e154 to
a3931b9
Compare
Contributor
Author
Owner
|
Looks good @MaxNau! I will merge and release this soon as 3.3.2. |
Owner
|
@MaxNau can you squash your commits into 1 commit (with signed off statement)? |
Signed-off-by: Max Nau <[email protected]> Signed-off-by: governor <[email protected]> Add integration test for default exchange publishing and consuming Signed-off-by: Max Nau <[email protected]> Signed-off-by: governor <[email protected]> Update readme with default exchange section Signed-off-by: governor <[email protected]> Add RabbitMqTopologyServiceTests Signed-off-by: governor <[email protected]> Add RabbitMqMessageBusSettingsValidationServiceTests Signed-off-by: governor <[email protected]>
MaxNau
force-pushed
the
feature/rabbitmq-default-exchange
branch
from
1c940fc to
c650665
Compare
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Host.RabbitMQ] Improve Validation and Default Exchange Handling
Enhances validation for consumer and producer settings to properly support the default exchange.
ℹ️ This ensures correct behavior when working with the default exchange (
""), which is a pre-declared direct exchange that automatically binds queues by their name.