Skip to content

Conversation

@zdykstra
Copy link
Member

Move all ZFSBootMenu-specific arguments to the zbm.* argument space. Legacy values are still accepted in lieu of the new zbm. value, but will produce a warning on the kernel ring buffer. Timeout values have been expanded to work as follows:

zbm.timeout (or timeout) to set an explicit timeout option
OR zbm.show sets menu_timeout=-1 to force the main menu
OR zbm.skip sets menu_timeout=0 to skip the menu and directly boot BOOTFS
finally if none of these options are set, menu_timeout=10 is set.

The order of these tests might want to be flipped around to give precedence to zbm.show / zbm.skip - thoughts?

@zdykstra zdykstra requested a review from ahesford December 18, 2020 03:03
Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the "show" or "skip" options should take priority over "timeout", because the latter is more specific. Looks good as is.

@zdykstra
Copy link
Member Author

I'll have to have you re-review this after I write documentation for these new options / new option names.

@zdykstra zdykstra force-pushed the kcl-namespace branch 3 times, most recently from 525ce18 to 26c158c Compare December 20, 2020 05:56
@zdykstra zdykstra merged commit 70c3d70 into master Dec 20, 2020
@zdykstra zdykstra deleted the kcl-namespace branch December 20, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants